Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to matrix-sdk-crypto-nodejs@0.1.0-beta.3 to support Node 19 #278

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Update to matrix-sdk-crypto-nodejs@0.1.0-beta.3 to support Node 19 #278

merged 2 commits into from
Nov 18, 2022

Conversation

Half-Shot
Copy link
Contributor

This version fixes a bug that would have prevented the rust binary's from being downloaded successfully on Node 19.

@turt2live turt2live self-requested a review November 4, 2022 13:36
@Half-Shot Half-Shot mentioned this pull request Nov 10, 2022
Merged
@jaller94
Copy link
Contributor

PR that fixes the download: matrix-org/matrix-rust-sdk#1164

turt2live
turt2live approved these changes Nov 18, 2022
View reviewed changes
Copy link
Owner

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that technically Node 19 isn't supported by the bot-sdk at this time, but that will probably change soonish.

@turt2live turt2live merged commit 84153ec into turt2live:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Half-Shot @jaller94 @turt2live