Remove hardcoding JPEG as filetype in thumbnail URIs #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vurpo
reviewed
Jun 12, 2019
…chment mimetypes Co-Authored-By: Max Sandholm <max@sandholm.org>
Half-Shot
approved these changes
Jun 17, 2019
There was a problem hiding this comment.
Looks good. Can you sign off as per https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst (we need to link it in this project, but it applies to all matrix-org projects)
|
Signed-off-by: Derin Yarsuvat derin@ml1.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Slack now does pass on non-JPEGs as thumbnails. I wasn't able to send any file other than
jpegs, previously. This quick change removes the hard-coded ".jpeg" extensions from outgoing messages in favor of their reported file-type.