RTM API support #164
Merged
RTM API support #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
reviewed
Jul 22, 2019
|
I wonder if Mattermost has a RTM api which is (mostly) slack equivalent? If it does we could consider dropping webhooks and events completely? |
jaller94
added
the
T-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is currently usinghs/typescriptas a base for easy reading, but should be merged againstdevelopeventually)(This was meant to be a draft, but I failed to click the button)
This PR adds support for using the realtime messaging API for incoming slack messages. This means that rather than using HTTP push for events, they will come across webhooks which should be quicker, easier to setup and allows for special events like typing notifications.
This feature is also a hard blocker for things like deployment to Modular, because it makes setting up per-team events push vastly easier (events API can only push to one host and will push events from all teams, whereas this API can pull from any host and limit it to one team). It also means we don't need to pop open any ports.