Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTM API support #164

Merged
merged 11 commits into from Aug 29, 2019

Conversation

@Half-Shot
Copy link
Contributor

commented Jul 19, 2019

(This is currently using hs/typescript as a base for easy reading, but should be merged against develop eventually)

(This was meant to be a draft, but I failed to click the button)

This PR adds support for using the realtime messaging API for incoming slack messages. This means that rather than using HTTP push for events, they will come across webhooks which should be quicker, easier to setup and allows for special events like typing notifications.

This feature is also a hard blocker for things like deployment to Modular, because it makes setting up per-team events push vastly easier (events API can only push to one host and will push events from all teams, whereas this API can pull from any host and limit it to one team). It also means we don't need to pop open any ports.

src/SlackHandler.ts Outdated Show resolved Hide resolved
@Cadair

This comment has been minimized.

Copy link
Collaborator

commented Jul 22, 2019

I wonder if Mattermost has a RTM api which is (mostly) slack equivalent? If it does we could consider dropping webhooks and events completely?

@Half-Shot Half-Shot changed the title Initial prototype of RTM RTM API support Aug 27, 2019

@Half-Shot Half-Shot requested a review from matrix-org/bridges Aug 28, 2019

@Half-Shot Half-Shot changed the base branch from hs/typescript to develop Aug 28, 2019

@Half-Shot Half-Shot force-pushed the hs/rtm branch from 29f79ea to cd3026e Aug 28, 2019

@turt2live
Copy link
Member

left a comment

@Half-Shot Half-Shot merged commit fb75e9d into develop Aug 29, 2019

2 checks passed

buildkite/matrix-appservice-slack Build #61 passed (48 seconds)
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.