Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade packages #557

Merged
merged 3 commits into from
Jan 13, 2021
Merged

chore: Upgrade packages #557

merged 3 commits into from
Jan 13, 2021

Conversation

Half-Shot
Copy link
Contributor

Various package updates to minor versions. The upgrade to TS 4.1 needed me to update a few types.

@Half-Shot Half-Shot requested a review from a team January 12, 2021 13:36
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, question not blocking

"Slackdown": "Half-Shot/slackdown#efd8934a3d9c3bf0064c0b217c5cf6b62ee697e4",
"axios": "^0.20.0",
"@slack/web-api": "^5.15.0",
"Slackdown": "github:Half-Shot/slackdown#efd8934a3d9c3bf0064c0b217c5cf6b62ee697e4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why off mainline? Do we have an issue to track this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up creating #561. Thanks for keeping me honest :)

@Half-Shot Half-Shot merged commit f2a00a1 into develop Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants