MSC1961: Integration manager authentication APIs #1961

turt2live · 2019-04-09T03:36:59Z

Rendered
Upstream proposal: MSC1956 - Integrations API
Discussion room: #msc-integrations-api:t2bot.io
Implementation (IM): turt2live/matrix-dimension@57d585d
Implementation (Client): Incomplete

This is being contributed under the hat of "author of Dimension":

Signed-off-by: Travis Ralston <travis@t2bot.io>

proposals/1961-integrations-auth.md

See matrix-org/matrix-spec-proposals#1961

jaywink · 2019-08-05T12:42:03Z

proposals/1961-integrations-auth.md

+
+#### POST `/_matrix/integrations/v1/account/logout`
+
+Logs the token out, rendering it useless for future requests.


Should this say that all tokens associated with the user should be logged out, not just the token this request was made with?

nope, just the token that was requested. This MSC does not propose an equivalent for /logout/all

I guess the follow-up question is then; should IM's have a /account/deactivate? When a user deactivates their account, it would be good for clients to pass that information to the IM, to tell it that this user will no longer exist and that all possible tokens and user information should be deleted. Or should this be a different MSC?

Pinging @lampholder for the privacy side re IM's.

I'd make that a separate MSC. I'm trying to keep these integration manager MSCs tightly scoped to avoid creeping features, given they are all trying to introduce a whole new API surface. This particular MSC is scoped to just authentication: deactivation is a feature which affects authentication but is not required for authentication. For instance, an integration manager could just delete everything after the last token is logged out. Similarly, there is no API for listing how many tokens you have assigned to you (and logging them out).

turt2live · 2019-08-09T15:24:42Z

MSC2140 and various clients are going to require this in order to continue functioning. This also hasn't received a lot of feedback.

To get more feedback and to unblock some part of the work...

@mscbot fcp merge

mscbot · 2019-08-09T15:24:46Z

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

anoadragon453

Short, sweet and sane.

jaywink · 2019-08-15T09:16:45Z

All good here 👍

richvdh · 2019-08-16T09:38:00Z

I'm not familiar with the integrations API as it stands, but no objections from me here.

@mscbot reviewed

erikjohnston · 2019-08-16T09:46:05Z

Process question: will these MSCs land separately or only once the full "integrations api" MSC lands? I'm comfortable with saying these APIs look fine, but I can equally imagine that after we land a bunch of integration API related MSCs it becomes clear that already MSCed APIs need to change.

Maybe we basically say: "this MSC is part of the unstable integration API module" and then the final MSC basically says "stabilise the integration API module"?

turt2live · 2019-08-16T14:45:43Z

I'm not familiar with the integrations API as it stands, but no objections from me here.

ftr, there isn't one. This is part 1 of many to make it a thing.

mscbot · 2019-08-18T18:41:16Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2019-08-23T20:17:34Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As per MSC1961, add to the whitelisted integrations_widget_urls the new paths. This allows us to switch Scalar over to use the new path as default. Note, the legacy "scalar-staging.riot.im" is these days just a redirect to scalar-staging.vector.im, so there is no addition for that. It still needs Riot side whitelisting though for existing widgets. Refs: matrix-org/matrix-spec-proposals#1961

As per MSC1961, add to the whitelisted integrations_widget_urls the new paths. This allows us to switch Scalar over to use the new path as default. Note, the legacy "scalar-staging.riot.im" is these days just a redirect to scalar-staging.vector.im, so there is no addition for that. It still needs Riot side whitelisting though for existing widgets. Refs: matrix-org/matrix-spec-proposals#1961 Signed-off-by: Jason Robinson <jasonr@matrix.org>

turt2live · 2019-08-26T20:18:57Z

Implementations:

jaywink · 2019-08-30T11:34:28Z

This has now been implemented and deployed for Scalar as well.

Proposal for basic integration manager authentication APIs

d6d0f97

turt2live added proposal-in-review proposal A matrix spec change proposal labels Apr 9, 2019

turt2live changed the title ~~Proposal for basic integration manager authentication APIs~~ MSC1961: Integration manager authentication APIs Apr 9, 2019

Assign MSC number

0bab70c

This was referenced Apr 9, 2019

[WIP] MSC1956: Integrations API (base) #1956

Draft

MSC1959: Sticker picker API #1959

Open

turt2live mentioned this pull request Jun 20, 2019

MSC2140: Terms of Service for ISes and IMs #2140

Merged

turt2live added the integrations Integration (Manager) API label Jun 20, 2019

turt2live commented Jun 25, 2019

View reviewed changes

proposals/1961-integrations-auth.md Show resolved Hide resolved

turt2live added 2 commits June 27, 2019 20:44

Add option to use query string

d8283b9

Formatting

bfd8e52

turt2live added a commit to turt2live/matrix-dimension that referenced this pull request Jun 28, 2019

Implement MSC1961

57d585d

See matrix-org/matrix-spec-proposals#1961

Merge branch 'master' into travis/msc/integrations/auth

a2a7b7f

turt2live mentioned this pull request Jun 29, 2019

Placeholder issue for "integrations API" implementation turt2live/matrix-dimension#262

Open

7 tasks

jryans mentioned this pull request Jul 24, 2019

Identity server v2 API authentication element-hq/element-web#10408

Closed

This was referenced Jul 25, 2019

Identity server v2 API authentication element-hq/element-android#435

Closed

Identity server v2 API authentication element-hq/element-ios#2603

Closed

Identity server v2 API authentication element-hq/riot-android#3228

Closed

jaywink reviewed Aug 5, 2019

View reviewed changes

mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Aug 9, 2019

anoadragon453 approved these changes Aug 9, 2019

View reviewed changes

turt2live removed the proposal-in-review label Aug 12, 2019

turt2live mentioned this pull request Aug 15, 2019

Placeholder issue for MSCs that should land prior to the privacy release element-hq/element-web#10574

Closed

6 tasks

Disclose origin story

475c64d

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Aug 18, 2019

mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Aug 23, 2019

turt2live merged commit 4ad9bf7 into master Aug 23, 2019

turt2live deleted the travis/msc/integrations/auth branch August 23, 2019 20:24

jaywink mentioned this pull request Aug 26, 2019

Change integrations_widgets_urls default configuration element-hq/element-web#10656

Merged

jaywink mentioned this pull request Aug 26, 2019

Add and prioritize the new "_matrix/integrations/v1" widget urls element-hq/element-ios#2669

Merged

jaywink mentioned this pull request Aug 26, 2019

Add and prioritize the new "_matrix/integrations/v1" widget urls element-hq/riot-android#3274

Merged

turt2live self-assigned this Aug 26, 2019

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Aug 26, 2019

turt2live added this to Needs spec in Client-server r0.6 proposals Aug 26, 2019

turt2live mentioned this pull request Aug 28, 2019

Placeholder for PRs regarding identity spec #2253

Closed

10 tasks

turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 20, 2020

turt2live added the blocked Something needs to be done before action can be taken on this PR/issue. label Apr 6, 2021

richvdh added this to Needs spec in Spec Core Team Backlog Feb 22, 2022

turt2live added this to Needs idea feedback / initial review in Spec Core Team Backlog via automation Dec 21, 2023

turt2live moved this from Needs idea feedback / initial review to BLOCKED, requires spec writing in Spec Core Team Backlog Dec 21, 2023

NicolasBuquet mentioned this pull request Feb 6, 2024

Etude : OpenID dans Tchap iOS tchapgouv/tchap-ios#965

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC1961: Integration manager authentication APIs #1961

MSC1961: Integration manager authentication APIs #1961

turt2live commented Apr 9, 2019 •

edited by anoadragon453

jaywink Aug 5, 2019

turt2live Aug 5, 2019

jaywink Aug 12, 2019

turt2live Aug 12, 2019

turt2live commented Aug 9, 2019

mscbot commented Aug 9, 2019 •

edited by KitsuneRal

anoadragon453 left a comment

jaywink commented Aug 15, 2019

richvdh commented Aug 16, 2019

erikjohnston commented Aug 16, 2019

turt2live commented Aug 16, 2019

mscbot commented Aug 18, 2019

mscbot commented Aug 23, 2019

turt2live commented Aug 26, 2019

jaywink commented Aug 30, 2019


		#### POST `/_matrix/integrations/v1/account/logout`

		Logs the token out, rendering it useless for future requests.

MSC1961: Integration manager authentication APIs #1961

MSC1961: Integration manager authentication APIs #1961

Conversation

turt2live commented Apr 9, 2019 • edited by anoadragon453

jaywink Aug 5, 2019

Choose a reason for hiding this comment

turt2live Aug 5, 2019

Choose a reason for hiding this comment

jaywink Aug 12, 2019

Choose a reason for hiding this comment

turt2live Aug 12, 2019

Choose a reason for hiding this comment

turt2live commented Aug 9, 2019

mscbot commented Aug 9, 2019 • edited by KitsuneRal

anoadragon453 left a comment

Choose a reason for hiding this comment

jaywink commented Aug 15, 2019

richvdh commented Aug 16, 2019

erikjohnston commented Aug 16, 2019

turt2live commented Aug 16, 2019

mscbot commented Aug 18, 2019

mscbot commented Aug 23, 2019

turt2live commented Aug 26, 2019

jaywink commented Aug 30, 2019

turt2live commented Apr 9, 2019 •

edited by anoadragon453

mscbot commented Aug 9, 2019 •

edited by KitsuneRal