Rename nonce to txn_id. Reorganize for clarity. #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-Off-By: Isaiah Inuwa <isaiah.inuwa@gmail.com>
turt2live
approved these changes
Dec 7, 2019
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
noncewas renamed totxn_idin 97154cc, but it wasn't updated in the description text below. Also, some of the information about thetokenwas interlaced with the information describing thetxn_id. I I reorganized it to have the related content grouped together.If someone has an opinion on whether the paragraph starting with "Additionally, " should be part of the paragraph above, that'd be good. I separated it since it was originally separate from the
tokendescription and seems to be answering the question "Why isn't the user id in the auth object?" rather than atoken-specific question.Signed-Off-By: Isaiah Inuwa isaiah.inuwa@gmail.com