New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move `invite_room_state` to the correct place in the client-server API #1568

Merged
merged 2 commits into from Aug 28, 2018

Conversation

2 participants
@turt2live
Member

turt2live commented Aug 27, 2018

Rendered: see 'docs' status check


Fixes #1350

@turt2live turt2live requested a review from matrix-org/spec-core-team Aug 27, 2018

@turt2live turt2live added this to In review (just the PRs) in August 2018 r0 via automation Aug 27, 2018

@ara4n

This comment has been minimized.

Member

ara4n commented Aug 28, 2018

Hum. It's worth noting that the various SDKs expect it to not be in the unsigned block, and the spec was once correct:

sierra:matrix-js-sdk matthew$ grep -r invite_room_state src
src/models/room.js:        const strippedStateEvents = membershipEvent.event.invite_room_state || [];

This presumably explains why all the Riots no longer give you nice details when you're invited to a room.

Looks like v1 had these on the raw event, and v2 moved them to unsigned. But nobody remembered to update the spec or the clients :|

@ara4n

ara4n approved these changes Aug 28, 2018

lgtm! i wonder what other "it's been broken since dec 2014" issues we have out there...

@turt2live turt2live merged commit ee2ebe6 into matrix-org:master Aug 28, 2018

4 checks passed

ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

August 2018 r0 automation moved this from Reviewer approved to Done (this list will be incomplete) Aug 28, 2018

@turt2live turt2live deleted the turt2live:travis/c2s/invite-room-state branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment