MSC 1659 Proposal: Change Event IDs to Hashes #1659

erikjohnston · 2018-09-05T08:37:00Z

~~PR for #1640~~ MSC has been renumbered to match this PR number

jevolk · 2018-09-05T10:23:01Z

https://matrix.org/docs/spec/server_server/unstable.html#put-matrix-federation-v1-invite-roomid-eventid

ara4n · 2018-09-05T21:32:27Z

@jevolk is your point that the eventId param may be redundant given it's now determinable from the event?

jevolk · 2018-09-05T22:11:45Z

@ara4n No. This is just an area of the spec which complicates event_id-as-hashes because the payload is modified by two parties as the target server's signature is added. This has to be considered when specifying the behavior of the invite process. The target server might not be online when the process is initiated. Can an invite be made when the target server is not online? If not, why is it such a big deal to even have the target's signature before persisting the event both locally and broadcasting to the room DAG. Is that signature necessary? These are rhetorical questions at this point but the point is that this area needs to be reconsidered.

proposals/1640-event-id-as-hashes.md

richvdh

I note that the reference hash does not currently include the signatures on the event. I assume you're proposing to maintain that behaviour? I don't think it causes any security problems, but it might be a good time to revisit it?

erikjohnston · 2018-10-02T13:38:36Z

This is just an area of the spec which complicates event_id-as-hashes because the payload is modified by two parties as the target server's signature is added

We should probably spell out clearly that signature fields aren't included in the hash. (The protocol assumes in several places that adding signatures don't break hashes).

erikjohnston · 2018-10-03T08:25:19Z

I note that the reference hash does not currently include the signatures on the event. I assume you're proposing to maintain that behaviour? I don't think it causes any security problems, but it might be a good time to revisit it?

Yup. I'm not particularly keen to change that behaviour as it feels reasonable to be able to add signatures without changing the ID of the event tbh.

proposals/1640-event-id-as-hashes.md

uhoreg

looks reasonable, with just a couple minor issues

proposals/1640-event-id-as-hashes.md

Co-Authored-By: erikjohnston <erikj@jki.re>

turt2live · 2019-01-24T18:22:57Z

proposals/1659-event-id-as-hashes.md

+event to clients, however.
+
+Note that the `auth_events` and `prev_events` fields aren't sent to clients, and
+so the changes proposed above won't affect clients.


unless they use the federation event format, but then they're on their own anyways.

proposals/1659-event-id-as-hashes.md

erikjohnston · 2019-01-24T18:46:19Z

Heads up that I've updated this MSC to include making a room v3

mscbot · 2019-01-25T16:32:40Z

🔔 This is now entering its final comment period, as per the review above. 🔔

neilisfragile · 2019-01-29T17:34:04Z

Room v3 should be considered a stable room version - I've made this explicit on the proposal.

proposals/1659-event-id-as-hashes.md

Co-Authored-By: erikjohnston <erikj@jki.re>

mscbot · 2019-01-30T17:02:27Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

mscbot · 2019-01-30T17:02:27Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

mscbot · 2019-01-30T17:02:27Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

Original proposal: #1659 Implementation proofs (some traversing of the PR tree may be required to get all of them): * matrix-org/synapse#4483 * matrix-org/synapse#4499 This doesn't intentionally change anything from the proposal. **Implementation details**: The simple part of this is the introduction of a rooms/v3.html document. The somewhat unclear part is the stuff done to the s2s definitions. This pulls `unsigned_pdu` out to `unsigned_pdu_base` (all fields except `event_id`) where it can be reused in `pdu` and `pdu_v3` (for rooms v3). These definitions are further moved into the room version specifications where they can highlight the exact schemas in detail. Version 1 has been updated to include the pre-existing event format, however the core principles of the room have not been changed. The same applies to room version 2. Room versions have immutable core principles once in the spec, otherwise these format changes would land in a pre-existing version. The client-server API event formats will need updating, however that is being punted to a different commit to try and keep these changes reviewable.

turt2live · 2019-02-01T00:59:51Z

merged via #1828 🎉

MSC 1640 Proposal: Change Event IDs to Hashes

67c6edb

erikjohnston requested a review from a team September 5, 2018 08:37

turt2live added the proposal-pr label Sep 5, 2018

turt2live added this to In review (just the PRs) in August 2018 r0 via automation Sep 5, 2018

erikjohnston mentioned this pull request Sep 6, 2018

MSC: Replace event IDs with hashes #1640

Closed

turt2live added the T-Core label Sep 10, 2018

richvdh reviewed Sep 19, 2018

View reviewed changes

proposals/1640-event-id-as-hashes.md Outdated Show resolved Hide resolved

proposals/1640-event-id-as-hashes.md Outdated Show resolved Hide resolved

richvdh requested changes Sep 19, 2018

View reviewed changes

neilisfragile added this to To Do in Superceded by https://github.com/orgs/matrix-org/projects/8 via automation Sep 21, 2018

neilisfragile moved this from To Do to In Progress: Planned Project Work in Superceded by https://github.com/orgs/matrix-org/projects/8 Sep 21, 2018

richvdh removed this from In Progress: Planned Project Work in Superceded by https://github.com/orgs/matrix-org/projects/8 Sep 28, 2018

erikjohnston self-assigned this Oct 2, 2018

Update with conclusions of open questions

4c595fd

richvdh requested changes Nov 7, 2018

View reviewed changes

anoadragon453 added proposal A matrix spec change proposal and removed T-Core labels Jan 4, 2019

erikjohnston added 5 commits January 22, 2019 13:57

Fixup paragraph

9a87a80

Fixup and expand

aebdf2e

Spell out changes to event format and APIs

5e75c29

Expand changes to api section

cb51a11

Grammar

54d9a7e

erikjohnston force-pushed the erikj/event_id_hashes branch from 950d27a to 54d9a7e Compare January 22, 2019 17:05

Make the sentence make sense

25115c4

uhoreg reviewed Jan 22, 2019

View reviewed changes

proposals/1640-event-id-as-hashes.md Outdated Show resolved Hide resolved

proposals/1640-event-id-as-hashes.md Outdated Show resolved Hide resolved

Update proposals/1640-event-id-as-hashes.md

74f496b

Co-Authored-By: erikjohnston <erikj@jki.re>

turt2live reviewed Jan 24, 2019

View reviewed changes

Explicitly state this will be a new v3 room version

ad96ae0

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 25, 2019

Update 1659-event-id-as-hashes.md

af34773

KitsuneRal approved these changes Jan 30, 2019

View reviewed changes

proposals/1659-event-id-as-hashes.md Outdated Show resolved Hide resolved

Update proposals/1659-event-id-as-hashes.md

66dc771

Co-Authored-By: erikjohnston <erikj@jki.re>

mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 30, 2019

erikjohnston merged commit 1c0742e into master Jan 30, 2019

erikjohnston mentioned this pull request Jan 30, 2019

Event ID's should be hashes and the hashes field should not exist. #1127

Closed

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels Jan 31, 2019

turt2live mentioned this pull request Jan 31, 2019

Add specification for room version 3: Event IDs as hashes #1828

Merged

turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 1, 2019

This was referenced Feb 8, 2019

Escape eventIds in CS API requests element-hq/riot-meta#261

Closed

Escape eventIds in CS API requests element-hq/riot-android#2934

Closed

Escape eventIds in CS API requests element-hq/element-ios#2236

Closed

richvdh mentioned this pull request Mar 18, 2019

We need to actually check the reference hashes on received events (SYN-185) matrix-org/synapse#1252

Closed

turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 21, 2020

KitsuneRal mentioned this pull request Nov 3, 2020

Clarify that event IDs are globally unique #2779

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC 1659 Proposal: Change Event IDs to Hashes #1659

MSC 1659 Proposal: Change Event IDs to Hashes #1659

erikjohnston commented Sep 5, 2018 •

edited by uhoreg

Loading

jevolk commented Sep 5, 2018

ara4n commented Sep 5, 2018

jevolk commented Sep 5, 2018

richvdh left a comment

erikjohnston commented Oct 2, 2018

erikjohnston commented Oct 3, 2018

uhoreg left a comment

turt2live Jan 24, 2019

erikjohnston commented Jan 24, 2019

mscbot commented Jan 25, 2019

neilisfragile commented Jan 29, 2019

mscbot commented Jan 30, 2019

mscbot commented Jan 30, 2019

mscbot commented Jan 30, 2019

turt2live commented Feb 1, 2019

MSC 1659 Proposal: Change Event IDs to Hashes #1659

MSC 1659 Proposal: Change Event IDs to Hashes #1659

Conversation

erikjohnston commented Sep 5, 2018 • edited by uhoreg Loading

jevolk commented Sep 5, 2018

ara4n commented Sep 5, 2018

jevolk commented Sep 5, 2018

richvdh left a comment

Choose a reason for hiding this comment

erikjohnston commented Oct 2, 2018

erikjohnston commented Oct 3, 2018

uhoreg left a comment

Choose a reason for hiding this comment

turt2live Jan 24, 2019

Choose a reason for hiding this comment

erikjohnston commented Jan 24, 2019

mscbot commented Jan 25, 2019

neilisfragile commented Jan 29, 2019

mscbot commented Jan 30, 2019

mscbot commented Jan 30, 2019

mscbot commented Jan 30, 2019

turt2live commented Feb 1, 2019

erikjohnston commented Sep 5, 2018 •

edited by uhoreg

Loading