Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape eventIds in CS API requests #2236

Closed
manuroe opened this issue Feb 8, 2019 · 3 comments
Closed

Escape eventIds in CS API requests #2236

manuroe opened this issue Feb 8, 2019 · 3 comments
Labels

Comments

@manuroe
Copy link
Member

manuroe commented Feb 8, 2019

@manuroe commented on Fri Feb 08 2019

Event IDs in room version 3 can now include hashes in them according to MSC1659.

APIs that must be checked:

/admin/purge_history/(?P<room_id>[^/]*)(/(?P<event_id>[^/]+))?
/events/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/report/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/event/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/context/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/redact/(?P<event_id>[^/]*)
/rooms/(?P<room_id>[^/]*)/receipt/(?P<receipt_type>[^/]*)/(?P<event_id>[^/]*)$

@manuroe manuroe added this to the Sprint 17 milestone Feb 8, 2019
@manuroe manuroe added the P1 label Feb 8, 2019
@fridtjof
Copy link
Contributor

fridtjof commented Feb 8, 2019

This issue should go into the matrix-ios-sdk repository, as the API calls are done there.

@manuroe
Copy link
Member Author

manuroe commented Feb 13, 2019

@fridtjof, you are absolutely right. This is a SDK issue but to ease project management across the 3 GH repos (Riot, MatrixKit, MatrixSDK), we report issues in the Riot one and track them per sprint into a Riot milestone. https://github.com/vector-im/riot-ios/milestone/21 for that issue.

@manuroe
Copy link
Member Author

manuroe commented Feb 13, 2019

Fixed by matrix-org/matrix-ios-sdk#632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants