This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Implement event format V2 #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4483 +/- ##
===========================================
- Coverage 74.75% 74.69% -0.06%
===========================================
Files 336 336
Lines 34219 34256 +37
Branches 5570 5578 +8
===========================================
+ Hits 25580 25589 +9
- Misses 7060 7086 +26
- Partials 1579 1581 +2 |
erikjohnston
force-pushed
the
erikj/event_v2
branch
4 times, most recently
from
7166bcb
to
3425d2c
Compare
erikjohnston
force-pushed
the
erikj/event_v2
branch
from
3425d2c
to
3680bc1
Compare
turt2live
added a commit
to matrix-org/matrix-spec-proposals
that referenced
this pull request
Jan 31, 2019
Original proposal: #1659 Implementation proofs (some traversing of the PR tree may be required to get all of them): * matrix-org/synapse#4483 * matrix-org/synapse#4499 This doesn't intentionally change anything from the proposal. **Implementation details**: The simple part of this is the introduction of a rooms/v3.html document. The somewhat unclear part is the stuff done to the s2s definitions. This pulls `unsigned_pdu` out to `unsigned_pdu_base` (all fields except `event_id`) where it can be reused in `pdu` and `pdu_v3` (for rooms v3). These definitions are further moved into the room version specifications where they can highlight the exact schemas in detail. Version 1 has been updated to include the pre-existing event format, however the core principles of the room have not been changed. The same applies to room version 2. Room versions have immutable core principles once in the spec, otherwise these format changes would land in a pre-existing version. The client-server API event formats will need updating, however that is being punted to a different commit to try and keep these changes reviewable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this merge it will just be a case of merging all the relevant PRs and enabling room version V3 support
Based on #4514