New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement event format V2 #4483

Merged
merged 2 commits into from Jan 29, 2019

Conversation

3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 25, 2019

Once this merge it will just be a case of merging all the relevant PRs and enabling room version V3 support

Based on #4514

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #4483 into develop will decrease coverage by 0.05%.
The diff coverage is 38.77%.

@@             Coverage Diff             @@
##           develop    #4483      +/-   ##
===========================================
- Coverage    74.75%   74.69%   -0.06%     
===========================================
  Files          336      336              
  Lines        34219    34256      +37     
  Branches      5570     5578       +8     
===========================================
+ Hits         25580    25589       +9     
- Misses        7060     7086      +26     
- Partials      1579     1581       +2

@erikjohnston erikjohnston force-pushed the erikj/event_v2 branch 4 times, most recently from 7166bcb to 3425d2c Jan 25, 2019

@erikjohnston erikjohnston changed the title [WIP] Implement MSC 1659 Implement event format V2 Jan 29, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 29, 2019

@erikjohnston erikjohnston force-pushed the erikj/event_v2 branch from 3425d2c to 3680bc1 Jan 29, 2019

@erikjohnston erikjohnston added this to To Do in Homeserver Task Board via automation Jan 29, 2019

@erikjohnston erikjohnston moved this from To Do to In progress in Homeserver Task Board Jan 29, 2019

@richvdh
Copy link
Member

richvdh left a comment

looks plausible

@erikjohnston erikjohnston merged commit 6f9cdc2 into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh moved this from In progress to Done in Homeserver Task Board Jan 29, 2019

turt2live added a commit to matrix-org/matrix-doc that referenced this pull request Jan 31, 2019

Add specification for room version 3: Event IDs as hashes
Original proposal: #1659
Implementation proofs (some traversing of the PR tree may be required to get all of them):
* matrix-org/synapse#4483
* matrix-org/synapse#4499

This doesn't intentionally change anything from the proposal.

**Implementation details**:

The simple part of this is the introduction of a rooms/v3.html document. The somewhat unclear part is the stuff done to the s2s definitions. This pulls `unsigned_pdu` out to `unsigned_pdu_base` (all fields except `event_id`) where it can be reused in `pdu` and `pdu_v3` (for rooms v3). These definitions are further moved into the room version specifications where they can highlight the exact schemas in detail.

Version 1 has been updated to include the pre-existing event format, however the core principles of the room have not been changed. The same applies to room version 2. Room versions have immutable core principles once in the spec, otherwise these format changes would land in a pre-existing version.

The client-server API event formats will need updating, however that is being punted to a different commit to try and keep these changes reviewable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment