Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC 1794 - Federation v2 Invite API #1794

Merged
merged 5 commits into from
Jan 21, 2019
Merged

MSC 1794 - Federation v2 Invite API #1794

merged 5 commits into from
Jan 21, 2019

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Jan 10, 2019 •
edited by babolivier

@erikjohnston erikjohnston changed the title MSC 1792 - Federation v2 Invite API MSC 1794 - Federation v2 Invite API Jan 10, 2019
@erikjohnston erikjohnston added proposal A matrix spec change proposal proposal-in-review labels Jan 10, 2019
@erikjohnston erikjohnston moved this from Holding pen to In Progress: Planned Project Work in Superceded by https://github.com/orgs/matrix-org/projects/8 Jan 10, 2019
@ara4n
Copy link
Member

ara4n commented Jan 11, 2019

looks eminently sane to me

richvdh
richvdh approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo grammatical nitpicking, short and sweet. Looks great.

proposals/1794-federation-v2-invites.md Outdated Show resolved Hide resolved
proposals/1794-federation-v2-invites.md Outdated Show resolved Hide resolved
@erikjohnston
Apply suggestions from code review
2109314 
Co-Authored-By: erikjohnston <erikj@jki.re>
@erikjohnston erikjohnston moved this from In Progress: Planned Project Work to Review in Superceded by https://github.com/orgs/matrix-org/projects/8 Jan 11, 2019
@turt2live
Copy link
Member

Looks like a good proposal from my end too. Thanks for writing it up!

uhoreg
uhoreg reviewed Jan 11, 2019
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits.

proposals/1794-federation-v2-invites.md Outdated Show resolved Hide resolved
proposals/1794-federation-v2-invites.md Outdated Show resolved Hide resolved
@erikjohnston
Copy link
Member Author

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jan 14, 2019 •
edited by uhoreg

Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jan 14, 2019
@erikjohnston erikjohnston mentioned this pull request Jan 14, 2019
Merged
@richvdh @erikjohnston
Update proposals/1794-federation-v2-invites.md
ebf3717 
Co-Authored-By: erikjohnston <erikj@jki.re>
@erikjohnston erikjohnston mentioned this pull request Jan 15, 2019
Merged
@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 15, 2019
@mscbot
Copy link
Collaborator

mscbot commented Jan 15, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@richvdh richvdh mentioned this pull request Jan 21, 2019
Closed
@mscbot
Copy link
Collaborator

mscbot commented Jan 21, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot removed the final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. label Jan 21, 2019
@turt2live turt2live merged commit f308871 into master Jan 21, 2019
turt2live
turt2live reviewed Jan 29, 2019
View reviewed changes
proposals/1794-federation-v2-invites.md
extra data to be added to the request payload separately from the event.
2. A required field called `"room_version"` is added that specifies the room
version.
3. The `"invite_room_state"` is moved from the `unsigned` section of the event
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on retrospect, I don't know if this is a good idea. We spent a lot of time going through the spec to make sure the invite_room_state was correctly documented to be under the unsigned object. Given this is for s2s communications though, this is probably fine.

turt2live added a commit that referenced this pull request Jan 29, 2019
@turt2live
Specification for v2 s2s invite API
4cf189b 
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
turt2live added a commit that referenced this pull request Jan 29, 2019
@turt2live
Specification for v2 s2s invite API
aca9437 
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
@turt2live turt2live mentioned this pull request Jan 29, 2019
Merged
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review merged A proposal whose PR has merged into the spec! and removed finished-final-comment-period spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jan 29, 2019
@turt2live
Copy link
Member

Merged via #1820 🎉

@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
@afranke afranke deleted the erikj/fed_invite_v2 branch September 22, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg left review comments

@turt2live turt2live turt2live left review comments

@ara4n ara4n ara4n left review comments

@richvdh richvdh richvdh approved these changes

@Half-Shot Half-Shot Half-Shot left review comments

Assignees

@erikjohnston erikjohnston

Labels
disposition-merge kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@erikjohnston @ara4n @turt2live @mscbot @uhoreg @richvdh @Half-Shot @neilisfragile