New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC 1794 - Federation v2 Invite API #1794

Open
wants to merge 5 commits into
base: master
from

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Jan 10, 2019

@erikjohnston erikjohnston force-pushed the erikj/fed_invite_v2 branch from d71a60b to b0adfc6 Jan 10, 2019

@erikjohnston erikjohnston changed the title MSC 1792 - Federation v2 Invite API MSC 1794 - Federation v2 Invite API Jan 10, 2019

@erikjohnston erikjohnston added this to Holding pen in Backend Core Team via automation Jan 10, 2019

@erikjohnston erikjohnston moved this from Holding pen to In Progress: Planned Project Work in Backend Core Team Jan 10, 2019

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jan 11, 2019

looks eminently sane to me

@richvdh
Copy link
Member

richvdh left a comment

modulo grammatical nitpicking, short and sweet. Looks great.

Show resolved Hide resolved proposals/1794-federation-v2-invites.md Outdated
Show resolved Hide resolved proposals/1794-federation-v2-invites.md Outdated
Apply suggestions from code review
Co-Authored-By: erikjohnston <erikj@jki.re>

@erikjohnston erikjohnston moved this from In Progress: Planned Project Work to Review in Backend Core Team Jan 11, 2019

@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Jan 11, 2019

Looks like a good proposal from my end too. Thanks for writing it up!

@uhoreg
Copy link
Member

uhoreg left a comment

Just a couple nits.

Show resolved Hide resolved proposals/1794-federation-v2-invites.md Outdated
Show resolved Hide resolved proposals/1794-federation-v2-invites.md Outdated

uhoreg and others added some commits Jan 14, 2019

Update proposals/1794-federation-v2-invites.md
Co-Authored-By: erikjohnston <erikj@jki.re>
@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Jan 14, 2019

@mscbot fcp merge

@mscbot

This comment has been minimized.

Copy link
Collaborator

mscbot commented Jan 14, 2019

Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Update proposals/1794-federation-v2-invites.md
Co-Authored-By: erikjohnston <erikj@jki.re>
@mscbot

This comment has been minimized.

Copy link
Collaborator

mscbot commented Jan 15, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment