Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement fallback for V2 invite API #4496

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Conversation

erikjohnston
Copy link
Member

If the room version is either 1 or 2 then a server should retry failed
/v2/invite requests with the v1 API

If the room version is either 1 or 2 then a server should retry failed
`/v2/invite` requests with the v1 API
@erikjohnston erikjohnston requested a review from a team January 28, 2019 17:37
@codecov-io
Copy link

Codecov Report

Merging #4496 into develop will increase coverage by <.01%.
The diff coverage is 84%.

@@             Coverage Diff             @@
##           develop    #4496      +/-   ##
===========================================
+ Coverage    74.73%   74.74%   +<.01%     
===========================================
  Files          336      336              
  Lines        34148    34165      +17     
  Branches      5553     5556       +3     
===========================================
+ Hits         25520    25535      +15     
- Misses        7049     7050       +1     
- Partials      1579     1580       +1

turt2live added a commit to matrix-org/matrix-spec-proposals that referenced this pull request Jan 29, 2019
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
turt2live added a commit to matrix-org/matrix-spec-proposals that referenced this pull request Jan 29, 2019
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit ff37acb into develop Jan 29, 2019
@erikjohnston erikjohnston deleted the erikj/invite_fallback branch March 5, 2019 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants