New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fallback for V2 invite API #4496

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 28, 2019

If the room version is either 1 or 2 then a server should retry failed
/v2/invite requests with the v1 API

erikjohnston added some commits Jan 28, 2019

Implement fallback for V2 invite API
If the room version is either 1 or 2 then a server should retry failed
`/v2/invite` requests with the v1 API

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 28, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 28, 2019

Codecov Report

Merging #4496 into develop will increase coverage by <.01%.
The diff coverage is 84%.

@@             Coverage Diff             @@
##           develop    #4496      +/-   ##
===========================================
+ Coverage    74.73%   74.74%   +<.01%     
===========================================
  Files          336      336              
  Lines        34148    34165      +17     
  Branches      5553     5556       +3     
===========================================
+ Hits         25520    25535      +15     
- Misses        7049     7050       +1     
- Partials      1579     1580       +1

turt2live added a commit to matrix-org/matrix-doc that referenced this pull request Jan 29, 2019

Specification for v2 s2s invite API
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.

turt2live added a commit to matrix-org/matrix-doc that referenced this pull request Jan 29, 2019

Specification for v2 s2s invite API
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
@richvdh
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit ff37acb into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment