New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement server side of MSC1794 - Federation v2 Invite API #4402

Merged
merged 3 commits into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@erikjohnston
Copy link
Member

erikjohnston commented Jan 16, 2019

The MSC hasn't been merged yet, but is in FCP. We can always change the implementation in the (unlikely?) event the MSC changes.

Based on #4390

erikjohnston added some commits Jan 15, 2019

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Jan 16, 2019

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Jan 16, 2019

The error looks to be a race/bug that wasn't introduced by this PR, so can be ignored as I'll fix it separately

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #4402 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4402      +/-   ##
===========================================
+ Coverage    73.64%   73.66%   +0.01%     
===========================================
  Files          300      300              
  Lines        29789    29801      +12     
  Branches      4896     4896              
===========================================
+ Hits         21938    21952      +14     
+ Misses        6411     6409       -2     
  Partials      1440     1440
@richvdh
Copy link
Member

richvdh left a comment

lgtm (modulo comments on #4390), but we're gonna need some tests.

@erikjohnston erikjohnston merged commit 83f335b into develop Jan 21, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Jan 21, 2019

See matrix-org/sytest#545 for tests

turt2live added a commit to matrix-org/matrix-doc that referenced this pull request Jan 29, 2019

Specification for v2 s2s invite API
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.

turt2live added a commit to matrix-org/matrix-doc that referenced this pull request Jan 29, 2019

Specification for v2 s2s invite API
Original proposal: #1794
Implementation proofs:
* matrix-org/synapse#4402
* matrix-org/synapse#4496

There are no changes from the original proposal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment