MSC3550: Allow HTTP 403 as a response to profile lookups #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
changed the title
turt2live
reviewed
Dec 7, 2021
turt2live
added
client-server
|
Thanks for the review, @turt2live! This is my first one of these so let me know if there's anything else I am missing. |
KitsuneRal
approved these changes
Dec 12, 2021
turt2live
approved these changes
Dec 13, 2021
|
This seems relatively straightforward. @mscbot fcp merge |
|
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
mscbot
added
disposition-merge
proposed-final-comment-period
turt2live
removed
the
needs-implementation
turt2live
added this to Needs idea feedback / initial review
in Spec Core Team Backlog
via automation
turt2live
moved this from Needs idea feedback / initial review
to Ready for FCP ticks
in Spec Core Team Backlog
Co-authored-by: Travis Ralston <travisr@matrix.org>
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
mscbot
added
final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. |
mscbot
added
finished-final-comment-period
and removed
disposition-merge
final-comment-period
turt2live
moved this from Ready for FCP ticks
to Done to some definition
in Spec Core Team Backlog
turt2live
added
spec-pr-in-review
|
Merged 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a MSC proposal generated in response to the feedback on #3530.
Essentially, servers (such as Synapse) may not allow profile lookup over federation. For example, Synapse will return an HTTP 403 in response to
GET /_matrix/client/v3/profile/{userId}ifallow_profile_lookup_over_federationis set toFalse. This behavior is not currently documented in the spec. This proposal aims to add HTTP 403 to the list of responses toGET /_matrix/client/v3/profile/{userId}.Signed off by: H.Shay hillerys@element.io
Rendered: https://github.com/matrix-org/matrix-doc/blob/3ce9c1d288aa3173caf2716b18e2a8da0bc681d7/proposals/3550-allow-403-response-profile-lookup.md
PR where this behavior was implemented: matrix-org/synapse#9203
Preview: https://pr3550--matrix-org-previews.netlify.app