This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
MXKRoomBubbleCellDataStoring: Introduce target user ID, display name and avatar URL for room membership events #793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in element-hq/element-ios#4102, collapsed membership changes in the Element iOS app currently always display the sender avatar. In contrast, the Element web app shows the avatar of the user whose membership has changed in this case.
This commit introduces new properties
targetId
,targetDisplayName
,targetAvatarUrl
andtargetAvatarPlaceholder
onMXKRoomBubbleCellDataStoring
. The values are populated from the event (in case it is anm.room.member
event) in the initializer ofMXKRoomBubbleCellData
(where the corresponding sender properties are already being assigned). This way, clients can easily choose to present the target avatar instead of the sender avatar when processing the bubble data.Note that the "target" terminology was taken over from matrix-js-sdk which populates the
target
property onMatrixEvent
objects when they are added to the timeline.Signed-off-by: Johannes Marbach n0-0ne+github@mailbox.org
Pull Request Checklist