Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoomVC: Senders of old messages have no display name nor avatar #4204

Closed
manuroe opened this issue Apr 12, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1068
Closed

RoomVC: Senders of old messages have no display name nor avatar #4204

manuroe opened this issue Apr 12, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1068
Assignees
@manuroe
Milestone
Sprint - Element ...

Comments

@manuroe
Copy link
Member

manuroe commented Apr 12, 2021

  1. Open a room
  2. Back paginate several times until fetching messages from the server not from the app cache
  3. -> senders of not cached messages have no display name, no avatar.

This may be a regression due to matrix-org/matrix-ios-kit#793.
@manuroe manuroe added this to the Sprint - Element 1.3.1 milestone Apr 12, 2021
@manuroe manuroe self-assigned this Apr 12, 2021
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Apr 14, 2021
@manuroe
MXRoomMembers: Fix wrong view of room members when paginating
ef97a9a 
element-hq/element-ios/issues/4204

Fix a regression introduced by #1040.
While paginating, the kept MXRoomState instance could be released, creating a bad view of room members. 

Remove the bad dependency to MXRoomState to avoid any retain cycle.
@manuroe manuroe mentioned this issue Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
None yet
Projects
None yet
Milestone
Sprint - Element 1.3.1
Development

Successfully merging a pull request may close this issue.

MXRoomMembers: Fix wrong view of room members when paginating matrix-org/matrix-ios-sdk
1 participant
@manuroe