Sorting room list alphabetically case-insensitive. #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2024 11:50
Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com>
Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com>
|
@pixlwave Can you have a look please. 🙏 |
pixlwave
reviewed
May 7, 2024
There was a problem hiding this comment.
Oh, thanks thats a nice little improvement. It might be better to use localizedStandardCompare here instead though, so the sorting is aligned with other places on the system?
|
@pixlwave Thanks 👍 |
pixlwave
approved these changes
May 7, 2024
There was a problem hiding this comment.
As mentioned in the guidelines, this file name should either be the issue number, or in this instance as there isn't one, pr-1851.change.
Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com>
denasescu
added a commit
to nedap/matrix-ios-sdk
that referenced
this pull request
Jun 7, 2024
* Prepare for new sprint * version++ * finish version++ * Prepare for new sprint * Add own device creation ts in crypto API * deviceCreationTs should be readonly * version++ * finish version++ * Prepare for new sprint * Sorting room list alphabetically case-insensitive. (matrix-org#1851) * Sort Room list alphabetically but caseInsensitive Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> * Sort Room list alphabetically but caseInsensitive Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> * Sort Room list alphabetically but caseInsensitive Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> --------- Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> Co-authored-by: Nicolas Buquet <nbuquet@buquet-net.com> * Bump rust crypto sdk version 0.4.1 * update minimum ios platform 13.0 * Update min deployment target to 13.0 * Update osx min platform * update podfile lock * Fix test compilation * Add changelog * Invalidate crypto store cache when entering foreground * Bump crypto sdk to 0.4.2 * Fix warnings * Bump the Crypto version in the podspec as well * version++ * finish version++ * BER-359: update changelog --------- Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> Co-authored-by: Mauro Romito <mauro.romito@element.io> Co-authored-by: Stefan Ceriu <stefan.ceriu@gmail.com> Co-authored-by: Stefan Ceriu <stefanc@matrix.org> Co-authored-by: Valere <bill.carson@valrsoft.com> Co-authored-by: Valere <valeref@matrix.org> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Nicolas Buquet <github@buquet-net.com> Co-authored-by: Nicolas Buquet <nbuquet@buquet-net.com>
denasescu
added a commit
to nedap/matrix-ios-sdk
that referenced
this pull request
Sep 3, 2024
* Prepare for new sprint * version++ * finish version++ * Prepare for new sprint * Add own device creation ts in crypto API * deviceCreationTs should be readonly * version++ * finish version++ * Prepare for new sprint * Sorting room list alphabetically case-insensitive. (matrix-org#1851) * Sort Room list alphabetically but caseInsensitive Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> * Sort Room list alphabetically but caseInsensitive Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> * Sort Room list alphabetically but caseInsensitive Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> --------- Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> Co-authored-by: Nicolas Buquet <nbuquet@buquet-net.com> * Bump rust crypto sdk version 0.4.1 * update minimum ios platform 13.0 * Update min deployment target to 13.0 * Update osx min platform * update podfile lock * Fix test compilation * Add changelog * Invalidate crypto store cache when entering foreground * Bump crypto sdk to 0.4.2 * Fix warnings * Bump the Crypto version in the podspec as well * version++ * finish version++ * Prepare for new sprint * Fix | Share room keys with dehydrated devices with rust stack * Add RestClient method for reporting rooms through MSC4151 * version++ * finish version++ * Prepare for new sprint * Add a new state event type: "m.room.retention" # Conflicts: # MatrixSDK/Contrib/Swift/JSONModels/MXEvent.swift # MatrixSDK/JSONModels/MXEvent.h # MatrixSDK/JSONModels/MXEvent.m # MatrixSDK/Utils/MXTools.m * added some functions to remove messages before a certain timestamp * remove all messages sent * fixing a compilation error * version++ * finish version++ * Prepare for new sprint * Update README. (matrix-org#1863) * fix store issue * version++ * finish version++ * Prepare for new sprint * Fix CallKit audio session late init Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> * Expose MXRoomPowerLevels Swift wrappers to Element (matrix-org#1869) Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> Co-authored-by: Nicolas Buquet <nbuquet@buquet-net.com> * implemented for the preview url API * removing return used for testing * using rest client instead of the home server directly * added the access token to the media loader request * implementation based on the server version * access token fix and using the stable endpoint prefix * documentation * code improvement * version++ * finish version++ * Prepare for new sprint * Add UTC timestamps to console logs * Create 7472.change * Bring in line with foundation DCO (matrix-org#1875) * bring in line with foundation DCO * add changelog entry --------- Co-authored-by: Josh Simmons <git@josh.tel> * Update format to include the time, Z cannot be applied to NSLog timestamps and doesn't do anything by itself * Use the codecov token. (matrix-org#1877) * Use the codecov token. * Use codecov v4? * version++ * finish version++ * BER-395: update changelog --------- Signed-off-by: Nicolas Buquet <nbuquet@buquet-net.com> Co-authored-by: Mauro Romito <mauro.romito@element.io> Co-authored-by: Stefan Ceriu <stefan.ceriu@gmail.com> Co-authored-by: Stefan Ceriu <stefanc@matrix.org> Co-authored-by: Valere <bill.carson@valrsoft.com> Co-authored-by: Valere <valeref@matrix.org> Co-authored-by: Doug <douglase@element.io> Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com> Co-authored-by: Nicolas Buquet <github@buquet-net.com> Co-authored-by: Nicolas Buquet <nbuquet@buquet-net.com> Co-authored-by: Giom Foret <giom@matrix.org> Co-authored-by: Mauro <34335419+Velin92@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Josh Simmons <josh@openchapters.tech> Co-authored-by: Josh Simmons <git@josh.tel>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting room list alphabetically, sort it case-insensitive.
Pull Request Checklist