Use the v2 (hashed) lookup for identity server queries #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#10556 Implements [MSC2134](matrix-org/matrix-spec-proposals#2134) with assistance from [MSC2140](matrix-org/matrix-spec-proposals#2140) for auth. Note: this also changes all identity server requests to use JSON as a request body. URL encoded forms were allowed in v1 but deprecated in favour of JSON. v2 APIs do not allow URL encoded forms.
This was referenced Aug 21, 2019
jryans
approved these changes
Aug 22, 2019
| @@ -412,7 +412,7 @@ module.exports.MatrixHttpApi.prototype = { | |||
| if (method == 'GET') { | |||
| opts.qs = params; | |||
| } else if (typeof params === "object") { | |||
| opts.form = params; | |||
| opts.json = params; | |||
| } else if (typeof params === "string") { | |||
| // Assume the caller has serialised the body to JSON | |||
There was a problem hiding this comment.
Is it possible to remove this branch and all the places where I plopped JSON.stringify(params) in idServerRequest call sites? Your approach with opts.json seems much more sane, so it'd be nice to just do that everywhere...
There was a problem hiding this comment.
I can do that in a different PR, I'd rather not make this diff any harder to read if I can avoid it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10556
Implements MSC2134 with assistance from MSC2140 for auth.
Note: this also changes all identity server requests to use JSON as a request body. URL encoded forms were allowed in v1 but deprecated in favour of JSON. v2 APIs do not allow URL encoded forms.