Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the stack when we get a sync error #109

Merged
merged 2 commits into from
Mar 17, 2016
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 17, 2016

If we have the stack for an exception in the /sync loop, we should log it.

If we have the stack for an exception in the /sync loop, we should log it.
If we have e.stack, then it will include the description of the exception.
@dbkr
Copy link
Member

dbkr commented Mar 17, 2016

lgtm (thank you, this was really annoying me)

@dbkr dbkr assigned richvdh and unassigned dbkr Mar 17, 2016
richvdh added a commit that referenced this pull request Mar 17, 2016
Log the stack when we get a sync error
@richvdh richvdh merged commit a2861c5 into develop Mar 17, 2016
@richvdh richvdh deleted the rav/log_sync_error_stack branch March 17, 2016 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants