Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browser example #1875

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Improve browser example #1875

merged 4 commits into from
Aug 31, 2021

Conversation

psrpinto
Copy link
Contributor

@psrpinto psrpinto commented Aug 30, 2021

Fix errors in the console when running the browser example, and use HTTPS instead of HTTP.


Before:

before

After:

after


Here's what your changelog entry will look like:

✨ Features

Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
Signed-off-by: Paulo Pinto <paulo.pinto@automattic.com>
@psrpinto psrpinto requested a review from a team as a code owner August 30, 2021 13:27
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for working on that!

@germain-gg germain-gg merged commit fe98917 into matrix-org:develop Aug 31, 2021
@psrpinto psrpinto deleted the fix/browser-example branch August 31, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants