Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http-api MatrixError httpStatus vs http_status #2396

Merged
merged 1 commit into from
May 24, 2022
Merged

Fix http-api MatrixError httpStatus vs http_status #2396

merged 1 commit into from
May 24, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 23, 2022 •
edited by github-actions bot
Loading

The MatrixError type says its httpStatus

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label May 23, 2022
@t3chguy t3chguy requested a review from a team as a code owner May 23, 2022 19:55
@t3chguy t3chguy mentioned this pull request May 23, 2022
Merged
weeman1337
weeman1337 approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t3chguy t3chguy merged commit 81a6e48 into develop May 24, 2022
@t3chguy t3chguy deleted the t3chguy/thumbnail-fallback branch May 24, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @weeman1337