Fix notification counts for encrypted rooms with ignored event rules #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
changed the title
Half-Shot
requested review from
germain-gg
and removed request for
weeman1337 and
alunturner
Half-Shot
commented
Feb 6, 2023
Half-Shot
commented
Feb 6, 2023
Half-Shot
commented
Feb 7, 2023
germain-gg
approved these changes
Feb 14, 2023
| return; | ||
| } | ||
|
|
||
| if (oldHighlight !== newHighlight || currentHighlightCount > 0) { |
There was a problem hiding this comment.
Should it also check for actions.notify or does it affect, total and total only?
There was a problem hiding this comment.
I believe this is handled by the if statement below. This just checks the highlights specifically.
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Mar 15, 2023
* Add easy way to determine if the decryption failure is due to "DecryptionError: The sender has disabled encrypting to unverified devices." ([\matrix-org#3167](matrix-org#3167)). Contributed by @florianduros. * Polls: expose end event id on poll model ([\matrix-org#3160](matrix-org#3160)). Contributed by @kerryarchibald. * Polls: count undecryptable poll relations ([\matrix-org#3163](matrix-org#3163)). Contributed by @kerryarchibald. * Fix spec compliance issue around encrypted `m.relates_to` ([\matrix-org#3178](matrix-org#3178)). * Fix reactions in threads sometimes causing stuck notifications ([\matrix-org#3146](matrix-org#3146)). Fixes element-hq/element-web#24000. Contributed by @justjanne. * Better type guard parseTopicContent ([\matrix-org#3165](matrix-org#3165)). Fixes matrix-org/element-web-rageshakes#20177 and matrix-org/element-web-rageshakes#20178. * Fix a bug where events in encrypted rooms would sometimes erroneously increment the total unread counter after being processed locally. ([\matrix-org#3130](matrix-org#3130)). Fixes element-hq/element-web#24448. Contributed by @Half-Shot. * Stop the ICE disconnected timer on call terminate ([\matrix-org#3147](matrix-org#3147)). * Clear notifications when we can infer read status from receipts ([\matrix-org#3139](matrix-org#3139)). Fixes element-hq/element-web#23991. * Messages sent out of order after one message fails ([\matrix-org#3131](matrix-org#3131)). Fixes element-hq/element-web#22885 and element-hq/element-web#18942. Contributed by @justjanne.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#24448
Checklist
Notes: Fix a bug where events in encrypted rooms would sometimes erroneously increment the total unread counter after being processed locally.
This PR aims to fix the problem where currently events with pushrules calculated clientside that emit a
{notify: false}are still calculated as increasing the unread counter in a room. This refactors one of the critical functions for dealing with it, so please review with care.In terms of the changes here, we:
fixNotificationCountOnDecryptionfunction to avoid doing so many non-null assertions.Here's what your changelog entry will look like:
🐛 Bug Fixes