adjust beacon model to make beaconInfo definitely assigned in constructor #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
richvdh
approved these changes
Mar 9, 2023
src/models/beacon.ts
Outdated
Comment on lines
59
to
60
| // setBeaconInfo also assigns this._beaconInfo | ||
| // manually assign here to make tsc believe it is definitely assigned in constructor |
There was a problem hiding this comment.
You can also use private _beaconInfo!: BeaconInfoState; instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid in
strictNullCheckswork in react-sdk, remove unnecessary optional operator on_beaconInfoelement-hq/element-web#24756
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.