Use an opts object to construct GroupCall
#3343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
approved these changes
May 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SimonBrandner
force-pushed
the
SimonBrandner/feat/groupcall-opts
branch
from
094deac
to
06a5a1a
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
SimonBrandner/feat/groupcall-opts
branch
from
06a5a1a
to
bdfc67c
Compare
…at/groupcall-opts
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…at/groupcall-opts Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
|
Closing as this seems to have been abandoned, happy to re-review if re-opened and conflicts resolved |
|
Oops, maybe one day 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's what your changelog entry will look like:
✨ Features
GroupCall(#3343).