Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: Throw error if missing userId in CryptoApi.findVerificationRequestDMInProgress #3641

Merged
merged 1 commit into from
Aug 1, 2023
Merged

ElementR: Throw error if missing userId in CryptoApi.findVerificationRequestDMInProgress #3641

merged 1 commit into from
Aug 1, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jul 31, 2023 •
edited

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Needs matrix-org/matrix-react-sdk#11292

This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros changed the title Throw error if missing userId in `CryptoApi.findVerificationRequest… Throw error if missing userId in CryptoApi.findVerificationRequestDMInProgress Jul 31, 2023
@florianduros florianduros changed the title Throw error if missing userId in CryptoApi.findVerificationRequestDMInProgress ElementR: Throw error if missing userId in CryptoApi.findVerificationRequestDMInProgress Jul 31, 2023
@florianduros florianduros mentioned this pull request Jul 31, 2023
Closed
@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 31, 2023
@florianduros florianduros marked this pull request as ready for review July 31, 2023 15:26
@florianduros florianduros requested a review from a team as a code owner July 31, 2023 15:26
t3chguy
t3chguy approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@florianduros florianduros added this pull request to the merge queue Aug 1, 2023
Merged via the queue into develop with commit 2e9b34e Aug 1, 2023
40 of 42 checks passed
@florianduros florianduros deleted the florianduros/element-r/throw-error-findVerificationRequestDMInProgress branch August 1, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@florianduros @t3chguy