Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: Provide userId parameter to findVerificationRequestDMInProgress #11292

Merged
merged 3 commits into from
Aug 1, 2023
Merged

ElementR: Provide userId parameter to findVerificationRequestDMInProgress #11292

merged 3 commits into from
Aug 1, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jul 18, 2023 •
edited

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Needs matrix-org/matrix-js-sdk#3601

This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros changed the title Provide userId parameter to findVerificationRequestDMInProgress ElementR: Provide userId parameter to findVerificationRequestDMInProgress Jul 18, 2023
@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jul 18, 2023
@florianduros florianduros mentioned this pull request Jul 18, 2023
Merged
3 tasks
@florianduros florianduros changed the title ElementR: Provide userId parameter to findVerificationRequestDMInProgress ElementR: Provide userId parameter to findVerificationRequestDMInProgress Jul 18, 2023
@florianduros florianduros mentioned this pull request Jul 25, 2023
Closed
@florianduros florianduros added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Jul 31, 2023
@florianduros florianduros mentioned this pull request Jul 31, 2023
Merged
3 tasks
@florianduros florianduros marked this pull request as ready for review July 31, 2023 16:19
@florianduros florianduros requested a review from a team as a code owner July 31, 2023 16:19
@florianduros florianduros added this pull request to the merge queue Aug 1, 2023
Merged via the queue into develop with commit b2eac5b Aug 1, 2023
86 checks passed
@florianduros florianduros deleted the florianduros/element-r/findVerificationRequestDMInProgress branch August 1, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@florianduros @robintown