Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a case where joinRoom creates a duplicate Room object #3747

Merged
merged 4 commits into from Sep 25, 2023

Conversation

robintown
Copy link
Member

@robintown robintown commented Sep 22, 2023

When calling MatrixClient.joinRoom with a room alias, the method would create a new Room object, even if you were already present in that room. This changes its behavior to no-op, as the doc comment promises.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass

Here's what your changelog entry will look like:

馃悰 Bug Fixes

  • Fix a case where joinRoom creates a duplicate Room object (#3747).

When calling MatrixClient.joinRoom with a room alias, the method would create a new Room object, even if you were already present in that room. This changes its behavior to no-op, as the doc comment promises.
@robintown robintown requested a review from a team as a code owner September 22, 2023 19:15
@robintown robintown added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Sep 22, 2023
@germain-gg germain-gg removed their request for review September 25, 2023 08:52
@robintown robintown added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2023
@robintown robintown added this pull request to the merge queue Sep 25, 2023
Merged via the queue into matrix-org:develop with commit 8f90159 Sep 25, 2023
20 checks passed
@robintown robintown deleted the join-room-alias branch September 25, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants