Add getThirdpartyUser to base api #589
Conversation
Signed-off-by: Johannes Bornhold <johannes@bornhold.name>
|
|
||
| return this._http.authedRequestWithPrefix( | ||
| undefined, "GET", path, params, undefined, | ||
| httpApi.PREFIX_UNSTABLE, |
There was a problem hiding this comment.
This is in the v2 API now so if we're adding it, we should probably add it using the stable endpoint.
There was a problem hiding this comment.
Should the same be tweaked for getThirdpartyProtocols ? I assume they go together.
There was a problem hiding this comment.
Good question - since these are existing APIs, we should probably leave them using unstable for a while as not all servers will have updated to expose the APIs on the stable path yet.
|
Also please note you need to do the DCO signoff as per https://github.com/matrix-org/matrix-js-sdk/blob/master/CONTRIBUTING.rst |
|
Had the sign off already in the commit. I've added it into the PR comment as well. Does it work this way? |
|
oh, I missed that, either is fine (although if it's on the commits it should technically be on all of them) |
|
out of interest, what's holding this up? |
|
This appears ready to merge to me. It has been reviewed and comments were replied to. We have sign off on 1 of 2 commits and the PR as a whole, which seems like sufficient coverage. |
I investigated options to build a new bridge for XMPP and found that this API method would be very useful for it. My assumption is that it could be used to enhance the invite dialog in a way so that it also understands protocols and external IDs, similar to the way how the room directory currently works.
Signed-off-by: Johannes Bornhold johannes@bornhold.name