check whether notif level is undefined, because 0 is falsey
#651
Conversation
…failed Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
src/models/room-state.js
Outdated
| @@ -455,7 +455,7 @@ RoomState.prototype.mayTriggerNotifOfType = function(notifLevelKey, userId) { | |||
| powerLevelsEvent && | |||
| powerLevelsEvent.getContent() && | |||
| powerLevelsEvent.getContent().notifications && | |||
| powerLevelsEvent.getContent().notifications[notifLevelKey] | |||
| powerLevelsEvent.getContent().notifications[notifLevelKey] !== undefined | |||
There was a problem hiding this comment.
and if it's null, false, NaN, or []? Might be best to change the check to be something like this:
!isNaN(powerLevelsEvent.getContent().notifications[notifLevelKey])
&& typeof(powerLevelsEvent.getContent().notifications[notifLevelKey]) === 'number'
There was a problem hiding this comment.
I got impatient and switched it and the others in this file over to a utils method isNumber I added which does pretty much the above
|
I kept it consistent with the other checks but did a not NaN previously, will make another pr to change them all after this one. I guess here we're trusting the server to sanitize the values |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
src/utils.js
Outdated
| * Returns whether the given value is a finite number without type-coercion | ||
| * | ||
| * @param {*} value the value to test | ||
| * @return {boolean} whether ot not value is a finite number without type-coercion |
I don't think we are doing that here.
I can't see evidence of us doing that before. |
as in a local change before this commit I made, then went for |
so if you set
@roomnotif=0, then js-sdk would think its actually 50 :(Signed-off-by: Michael Telatynski 7t3chguy@gmail.com