Use new stop() method on matrix-mock-request #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To finish all pending flushes between tests. This stops the unit tests from hanging on node 11 when run in certain combinations. Requires matrix-org/matrix-mock-request#6 (so will need a release of matrix-mock-request before merging)
bwindels
approved these changes
Oct 25, 2018
bwindels
suggested changes
Oct 25, 2018
| @@ -105,6 +105,7 @@ TestClient.prototype.start = function() { | |||
| */ | |||
There was a problem hiding this comment.
lint error here:
/home/travis/build/matrix-org/matrix-js-sdk/spec/TestClient.js
103:1 error Missing JSDoc @returns for function valid-jsdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To finish all pending flushes between tests. This stops the unit
tests from hanging on node 11 when run in certain combinations.
Requires matrix-org/matrix-mock-request#6
(so will need a release of matrix-mock-request before merging)
For the record, one such combination was:
This would complete all the tests but hang spinning a CPU core instead of exiting. Adding
--exit(so mocha called process.exit once the tests were all done) made it exit. Addingspecbuild/integ/megolm-integ.spec.jswould cause it to hang before completing the tests.