This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Hide seek bar of audio player to fix a flaky Percy test temporarily #10430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
Z-Community-PR
richvdh
reviewed
Mar 23, 2023
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should temporarily fix a flaky Percy test of audio player on
FilePanelby hiding the seek bar whose indicator is not consistently rendered.Closes element-hq/element-web#24897
Here is an example of the flaky test: https://percy.io/dfde73bd/matrix-react-sdk/builds/26097295/changed/1454569038?browser=chrome&browser_ids=33%2C34%2C35%2C36&subcategories=unreviewed%2Cchanges_requested&viewLayout=overlay&viewMode=new&width=1920&widths=1024%2C1920
Here is a cropped screenshot of the test. The indicator is rendered on a different position on the seek bar.
The issue of the indicator was logged here too: element-hq/element-web#24898
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.