Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cypress Testing Library - crypto.spec.ts #10512

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Use Cypress Testing Library - crypto.spec.ts #10512

merged 2 commits into from
Apr 12, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 4, 2023 •
edited
Loading

For element-hq/element-web#25033

This PR intends to apply Cypress Testing Library to crypto.spec.ts.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 4, 2023
@luixxiul luixxiul mentioned this pull request Apr 5, 2023
Closed
36 tasks
@luixxiul
Update crypto.spec.ts - use Cypress Testing Library
30bc8f1 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul mentioned this pull request Apr 11, 2023
Closed
@luixxiul
Empty commit
511929c 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul marked this pull request as ready for review April 12, 2023 06:11
@luixxiul luixxiul requested a review from a team as a code owner April 12, 2023 06:11
richvdh
richvdh approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh added this pull request to the merge queue Apr 12, 2023
Merged via the queue into matrix-org:develop with commit c9c974d Apr 12, 2023
@luixxiul luixxiul deleted the test-crypto branch April 12, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luixxiul @richvdh