Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Cypress Testing Library to the existing E2E tests #25033

Closed
36 tasks done
luixxiul opened this issue Apr 5, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#10721
Closed
36 tasks done
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement

Comments

@luixxiul
Copy link

luixxiul commented Apr 5, 2023

matrix-org/matrix-react-sdk#10446 implemented Cypress Testing Library to align Jest tests and Cypress tests in terms of using Test Library (#24906 (comment)), and I think Cypress Testing Library should be applied to not only a new test but also the existing tests.

Here is a list of the current Cypress E2E tests.

  • analytics-toast.ts 10718
  • audio-player.spec.ts: 10537
  • composer.spec.ts: 10511 10538
  • consent.spec.ts: 10514
  • create-room.spec.ts 10542
  • crypto.spec.ts: 10512
  • decryption-failure.spec.ts: 10513 10541
  • device-management.spec.ts 10585
  • editing.spec.ts 10543
  • events.spec.ts 10590
  • file-panel.spec.ts 10574
  • get-openid-token.spec.ts 10586
  • hidden-rr-migration.spec.ts
  • kick.spec.ts 10587
  • layout.spec.ts
  • lazy-loading.spec.ts 10591
  • location.spec.ts 10612
  • login.spec.ts 10597
  • one-to-one-chat.spec.ts 10572
  • permalinks.spec.ts
  • pills-click-in-app.spec.ts 10582
  • pollHistory.spec.ts 10611
  • polls.spec.ts 10609
  • read_events.spec.ts 10719
  • register.spec.ts 10566
  • right-panel.spec.ts 10539
  • room-directory.spec.ts 10596
  • room.spec.ts 10608
  • send_event.spec.ts 10613
  • sliding-sync.ts 10618
  • spaces.spec.ts 10620
  • spotlight.spec.ts 10621
  • stickers.spec.ts 10622
  • threads.spec.ts 10680
  • timeline.spec.ts 10540 (partial) 10721
  • update.spec.ts
  • user-menu.spec.ts 10578
  • user-onboarding-new.ts 10728
  • user-onboarding-old.ts 10728
  • user-view.spec.ts 10577
  • widget-pip-close.spec.ts
  • Files inside support/ directory 10619

Please note that some of them do not require Cypress Testing Library, as they do not emulate interactions by users.

Have you considered any alternatives?

No response

Additional context

No response

@weeman1337
Copy link
Contributor

@luixxiul Thanks for writing the list about what to migrate. I would suggest that you pause your work on this issue for a few days until a decision on convenience functions has been made.

@luixxiul
Copy link
Author

luixxiul commented Apr 5, 2023

I understood. Fortunately it looks fairly easy to replace the lines of the existing PRs with regex in any case :-)

Edit: the functions have been removed.

@weeman1337
Copy link
Contributor

See this comment . The convenience functions are going to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Developer-Experience O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants