Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cypress/support/find.ts and custom commands on Cypress Testing Library #10544

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Remove cypress/support/find.ts and custom commands on Cypress Testing Library #10544

merged 1 commit into from
Apr 12, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 7, 2023

Closes element-hq/element-web#25058
Closes element-hq/element-web#25059

This PR intends to remove cypress/support/find.ts and custom commands for Cypress Testing Library, added by #10446.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 7, 2023
@luixxiul luixxiul changed the title Remove find.ts and custom commands on Cypress Testing Library Remove find.ts and custom commands on Cypress Testing Library Apr 7, 2023
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul changed the title Remove find.ts and custom commands on Cypress Testing Library Remove cypress/support/find.ts and custom commands on Cypress Testing Library Apr 11, 2023
@luixxiul luixxiul marked this pull request as ready for review April 11, 2023 11:38
@luixxiul luixxiul requested a review from a team as a code owner April 11, 2023 11:38
@weeman1337 weeman1337 added this pull request to the merge queue Apr 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2023
@t3chguy t3chguy added this pull request to the merge queue Apr 12, 2023
Merged via the queue into matrix-org:develop with commit 5316bb5 Apr 12, 2023
@luixxiul luixxiul deleted the test-find.ts branch April 12, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
3 participants