Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom commands on find.ts such as findButton #25058

Closed
6 tasks done
luixxiul opened this issue Apr 6, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#10544
Closed
6 tasks done

Remove custom commands on find.ts such as findButton #25058

luixxiul opened this issue Apr 6, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#10544

Comments

@luixxiul
Copy link

luixxiul commented Apr 6, 2023

Based on the internal discussion among employees on a private room and the comment here, the custom commands on find.ts such as findButton need to be removed.

Existing lines should be able to be easily replaced with regex, fortunately.

  • cypress/e2e/audio-player/audio-player.spec.ts - 10537
  • cypress/e2e/composer/composer.spec.ts - 10538
  • cypress/e2e/create-room/create-room.spec.ts - 10542
  • cypress/e2e/crypto/decryption-failure.spec.ts - 10541
  • cypress/e2e/editing/editing.spec.ts - 10543
  • cypress/e2e/timeline/timeline.spec.ts - 10540

Here is the list of E2E Cypress tests: #25033

@luixxiul
Copy link
Author

I confirmed those custom commands have been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants