This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Replace Sass variables and hard-coded values with CSS custom properties - _font-sizes.pcss
#10555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
Z-Community-PR
luixxiul
changed the title
_font-sizes.pcss
luixxiul
changed the title
_font-sizes.pcss_font-sizes.pcss
|
Updating this line on the code style guide will be required too. |
|
The build fails because there are several lines on |
|
Closing as I believe this must be irrelevant for Compound stuff, and there are too many conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes element-hq/element-web#25072
For element-hq/element-web#21656
This PR intends to replace Sass variables and hard-coded
font-sizevalues with variables specified on_font-sizes.pcssbased on the style guide, adding todo comments to lines which should be addressed.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.