Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user-view.spec.ts - use Cypress Testing Library #10577

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Update user-view.spec.ts - use Cypress Testing Library #10577

merged 2 commits into from
Apr 12, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 12, 2023

For element-hq/element-web#25033

This PR intends to update user-view.spec.ts by using Cypress Testing Library. It also removes a command to wait until the spinner disappears as percySnapshotElement waits it by default.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
The custom command 'percySnapshotElement' waits until it disappears so there is no need to keep it.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 12, 2023
@luixxiul luixxiul marked this pull request as ready for review April 12, 2023 12:16
@luixxiul luixxiul requested a review from a team as a code owner April 12, 2023 12:16
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@florianduros florianduros added this pull request to the merge queue Apr 12, 2023
Merged via the queue into matrix-org:develop with commit c5de595 Apr 12, 2023
@luixxiul luixxiul deleted the test-user-view branch April 12, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants