Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update events.spec.ts - use Cypress Testing Library #10590

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Update events.spec.ts - use Cypress Testing Library #10590

merged 1 commit into from
Apr 20, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 13, 2023 •
edited
Loading

For element-hq/element-web#25033

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@luixxiul
Update events.spec.ts - use Cypress Testing Library
4bae450 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 13, 2023
@luixxiul luixxiul mentioned this pull request Apr 13, 2023
Closed
36 tasks
@luixxiul luixxiul marked this pull request as ready for review April 13, 2023 06:03
@luixxiul luixxiul requested a review from a team as a code owner April 13, 2023 06:03
@luixxiul luixxiul requested review from dbkr and justjanne April 13, 2023 06:03
@t3chguy t3chguy added this pull request to the merge queue Apr 20, 2023
Merged via the queue into matrix-org:develop with commit 6b211dd Apr 20, 2023
@luixxiul luixxiul deleted the test-events branch April 20, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justjanne justjanne justjanne approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luixxiul @justjanne @t3chguy