Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update room-directory.spec.ts - use Cypress Testing Library #10596

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Update room-directory.spec.ts - use Cypress Testing Library #10596

merged 2 commits into from
Apr 17, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 13, 2023 •
edited
Loading

For element-hq/element-web#25033

This PR intends to update room-directory.spec.ts by using Cypress Testing Library.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@luixxiul
Update room-directory.spec.ts - use Cypress Testing Library
4579e90 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 13, 2023
@luixxiul luixxiul mentioned this pull request Apr 13, 2023
Closed
36 tasks
@luixxiul luixxiul marked this pull request as ready for review April 14, 2023 10:15
@luixxiul luixxiul requested a review from a team as a code owner April 14, 2023 10:15
florianduros
florianduros approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@florianduros florianduros added this pull request to the merge queue Apr 17, 2023
Merged via the queue into matrix-org:develop with commit 013b720 Apr 17, 2023
@luixxiul luixxiul deleted the test-room-directory branch April 17, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianduros florianduros florianduros approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luixxiul @florianduros