Update sliding-sync.spec.ts - use Cypress Testing Library
#10618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
The elements with ARIA "treeitem" role resides in ones with ARIA "group" role such as Favourites, People, and Invites. The elements with the "treeitem" role correspond to rooms on the room list. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ological order by default and allowing sorting A-Z' Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Note the Test room is excluded from being counted thanks to within(). Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Since it has been unclear "Join" etc. is a verb or a room name, the room names are changed as below: - Join -> Room to Join - Reject -> Room to Reject (the invite) - Rescind -> Room to Rescind (the invite) Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Have different ARIA labels specified for "mx_RoomSublist" and "mx_RoomSublist_headerContainer" to clarify the structure. Change the test to check the new ARIA label. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
Z-Community-PR
36 tasks
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
|
I'm no ARIA expert, but it would seem more logical to me to just have one element with the appropriate aria label rather than the header explicitly having a label saying that it's the header? |
|
I'm sorry, but I am not quite sure either... At first, I am going to update the test by not touching ARIA related stuff, leaving comments / creating an issue about it. |
This reverts commit 193a47d. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
|
@dbkr The change on ARIA stuff has been reverted. Would you kindly review again? |
luixxiul
changed the title
sliding-sync.spec.ts - use Cypress Testing Library and change ARIA label attributesliding-sync.spec.ts - use Cypress Testing Library
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#25033
This PR intends to update
sliding-sync.spec.tsby:Join,RejectandRescindtoRoom to Join,Room to RejectandRoom to Rescind, respectively, asfindByRole()this PR is going to add is used to search buttons as well, whose label texts are same as the rooms name. This change intends to avoid confusion due to the similarity (to avoid something like this: "Invite" button to search the room "Invite", etc.)type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.