-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the $spacing-
variables
#10686
Conversation
Will this deprecate this PR? #10552 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
* In future, we plan to introduce variables named according to their purpose rather than their size. Additionally, | ||
* we want switch to custom CSS properties (https://github.com/vector-im/element-web/issues/21656), so we might have | ||
* `--spacing-standard` or something. For now, you might as well use hardcoded px values for lengths (except for font | ||
* sizes, for which see the `$font-<N>px` variables). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be done as part of what https://github.com/vector-im/compound-design-tokens outputs.
I've commented on the linked issue to explain a rough path to a better future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Given element-hq/element-web#21656 (comment), I think it probably does, yes. |
Per matrix-org/matrix-react-sdk#10686, these don't make much sense at the moment.
Per matrix-org/matrix-react-sdk#10686, these don't make much sense at the moment.
The variables on _spacing.pcss have been deprecated by #10686
... and write some comments about the
$font-
variables.I think this is an accurate representation of what we discussed in our meeting yesterday, but would appreciate feedback.
If we're agreed on this I will follow up with an update to the
code_style
doc in element-web.This change is marked as an internal change (Task), so will not be included in the changelog.