-
-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate mixin ThreadSummaryIcon
#11023
Conversation
display: flex; | ||
align-items: center; | ||
column-gap: 8px; | ||
margin-bottom: 8px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note $spacing
variables have been deprecated: #10686
I'm struggling to increase the test coverage. Any pointers would be appreciated. |
Rename mx_ThreadSummary_icon to mx_ThreadSummary_info
Looking into the Sonar Cloud report adding a Jest test for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @luixxiul . I think this is a very valuable contribution. 👍 Replacing these mask-based and pseudo-element icons with a component will help with the compound migration.
Can you have a look at the Jest tests? If you need assistance there let me know.
res/css/_common.pcss
Outdated
@@ -694,6 +694,13 @@ legend { | |||
color: $username-variant8-color; | |||
} | |||
|
|||
.mx_Icon--thread { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not mandatory since the current icon stuff is temporary until Compound arrives™
You could add mx_Icon_18
and mx_Icon_secondary-content
here.
This comment was marked as off-topic.
This comment was marked as off-topic.
Closing as I am not quite sure how I should proceed from here… @weeman1337 thanks anyway for the review. |
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.