Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Emulate TabbedView's actual min and max widths on user settings tabs #10737

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Emulate TabbedView's actual min and max widths on user settings tabs #10737

merged 1 commit into from
Apr 28, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 28, 2023

Closes element-hq/element-web#25229

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 28, 2023
@luixxiul luixxiul marked this pull request as ready for review April 28, 2023 07:37
@luixxiul luixxiul requested a review from a team as a code owner April 28, 2023 07:37
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks for the detailed comments.

@dbkr dbkr added this pull request to the merge queue Apr 28, 2023
Merged via the queue into matrix-org:develop with commit 30ac950 Apr 28, 2023
@luixxiul luixxiul deleted the test-user-settings-tabs branch April 28, 2023 09:17
@luixxiul
Copy link
Contributor Author

luixxiul commented May 1, 2023

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Percy snapshots width of user settings tabs to emulate the actual UI
2 participants