Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update existing Cypress tests - use Cypress Testing Library #10755

Merged
merged 1 commit into from
May 1, 2023
Merged

Update existing Cypress tests - use Cypress Testing Library #10755

merged 1 commit into from
May 1, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 1, 2023 •
edited
Loading

For element-hq/element-web#25033

This PR intends to update existing Cypress tests to use Cypress Testing Library.

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@luixxiul
Update existing Cypress tests - use Cypress Testing Library
130ade5 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 1, 2023
@luixxiul luixxiul marked this pull request as ready for review May 1, 2023 07:23
@luixxiul luixxiul requested a review from a team as a code owner May 1, 2023 07:23
@luixxiul luixxiul requested review from dbkr and justjanne May 1, 2023 07:23
@kerryarchibald kerryarchibald added this pull request to the merge queue May 1, 2023
Merged via the queue into matrix-org:develop with commit a81940b May 1, 2023
@luixxiul luixxiul deleted the test branch May 2, 2023 08:53
@luixxiul
Copy link
Contributor Author

luixxiul commented May 2, 2023

thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from matrix-org/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luixxiul @kerryarchibald