Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Replace $timeline-image-border-radius with a CSS custom property #10792

Merged
merged 4 commits into from
May 9, 2023
Merged

Replace $timeline-image-border-radius with a CSS custom property #10792

merged 4 commits into from
May 9, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 4, 2023

For element-hq/element-web#21656

This PR proposes to replace $timeline-image-border-radius with a CSS custom property, renaming it to reflect the current usage (used for not only images on timeline but also M.*?Body components).

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

Remove the same variable from _MImageBody.pcss
The property is neither limited to a timeline nor image, but applied to M.*?Body components as well, such as MLocationBody and MVideoBody.
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 4, 2023
@luixxiul luixxiul marked this pull request as ready for review May 4, 2023 17:18
@luixxiul luixxiul requested a review from a team as a code owner May 4, 2023 17:18
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@andybalaam
Copy link
Contributor

@luixxiul please can you resolve conflicts so I can merge?

@germain-gg germain-gg removed their request for review May 9, 2023 14:55
@kerryarchibald kerryarchibald added this pull request to the merge queue May 9, 2023
Merged via the queue into matrix-org:develop with commit dc8ea8d May 9, 2023
@luixxiul luixxiul deleted the MBody-border-radius branch May 10, 2023 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants