This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Simplify references to VerificationRequest
#11045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
richvdh
force-pushed
the
rav/element-r/16_new_verificationrequest_methods
branch
from
5d0aecc
to
3a7cc3a
Compare
richvdh
force-pushed
the
rav/element-r/16_new_verificationrequest_methods
branch
from
3a7cc3a
to
6351297
Compare
richvdh
force-pushed
the
rav/element-r/16_new_verificationrequest_methods
branch
from
4f23330
to
8dcf36f
Compare
richvdh
force-pushed
the
rav/element-r/16_new_verificationrequest_methods
branch
from
8dcf36f
to
14f5515
Compare
Normally these are guarded by `request.initiatedByMe` so we can trivially replace it with `request.otherUserId` or `client.getUserId()`. In one place we actually need to apply some logic.
richvdh
force-pushed
the
rav/element-r/16_new_verificationrequest_methods
branch
from
14f5515
to
2c4a402
Compare
florianduros
approved these changes
Jun 6, 2023
…ew_verificationrequest_methods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-js-sdk#3441 adds some new methods to
VerificationRequestso that we can avoid direct references tochannelandqrCodeData. This PR makes use of the new methods, as well as removing references to some other fiddly methods like{requesting,receiving}UserId.Requires matrix-org/matrix-js-sdk#3441.
This change is marked as an internal change (Task), so will not be included in the changelog.