Replace SecurityCustomisations with CryptoSetupExtension
#12342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
thoraj
changed the title
3 tasks
|
I'm sorry this has taken so long for a decision.
I discussed this with the team last week; the answer was: we're not aware of anyone other than yourselves that are using |
richvdh
requested changes
Apr 4, 2024
richvdh
reviewed
Apr 11, 2024
richvdh
reviewed
Apr 11, 2024
richvdh
changed the title
SecurityCustomisations with CryptoSetupExtension
richvdh
added
the
T-Enhancement
Keep the flags to track implementations as direct properties Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
|
@richvdh Thanks a lot for the very thorough review. I have implemented your last suggestions. |
richvdh
reviewed
Apr 12, 2024
Fix whitespace Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
richvdh
approved these changes
Apr 12, 2024
MidhunSureshR
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for the changes required for the CryptoSetupExtension. The extension is described in this issue, and also in the corresponding PR in matrix-react-sdk-module-api. The module-api PR has been merged, and the changes were released in v2.4.0.
SecurityCustomisations
We have asked about the deprecation of the SecurityCustomisations here in GH, and in the Element Web Development room (#element-dev:matrix.org). A decision must be made if CryptoSetupExtension will replace SecurityCustomisations immediately, or if there need to be a period of overlap where both are supported? As of 15.03.2024 we have not received any response/information about the matter.
Important this PR will remove the calls to the obsolete SecurityCustomisations, and replace them with the corresponding calls to CryptoSetupExtension (via ModuleRunner). (I have left the old calls as comments)
The rationale is that until Verji asked about the SecurityCustomisations the Element team had no plans to port them since no-one had notified the Element team that they were using them. Furthermore, AFAIK the customisation mechanism as such is deprecated and will be removed in the future.
Dependencies
This PR depends on matrix-react-sdk-module-api v2.4.0+, hence the checks will fail until matrix-react-sdk bumps the dependency from 2.3.0 => 2.4.0
Checklist
public/exportedsymbols have accurate TSDoc documentation.Signed-off-by: Thor Arne Johansen taj@verji.com