Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the active tab in user settings to the dialog title #12481

Merged
merged 11 commits into from
May 7, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 1, 2024

Separated by a colon, as per the new design.

This makes UserSettings and RoomSettings start to diverge, but that's intentional for now.

Based on #12480

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

dbkr added 5 commits May 1, 2024 10:48
The 'Tab' is still a class, so now it's a functional component that
has a supporting class, which is maybe a bit... jarring, but I think
is actually perfectly logical.
This does mean the logic of keeping what tab is active is now in each
container component, but for a functional component, this is a single
line. It makes TabbedView simpler and the container components always
know exactly what tab is being displayed rather than having to effectively
keep the state separately themselves if they wanted it.

Based on #12478
Separated by a colon, as per the new design.
@dbkr dbkr added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label May 1, 2024
@dbkr dbkr added this pull request to the merge queue May 7, 2024
Merged via the queue into develop with commit 18ef971 May 7, 2024
30 checks passed
@dbkr dbkr deleted the dbkr/user_settings_title branch May 7, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants