Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the active tab in user settings to the dialog title #12481

Merged
merged 11 commits into from
May 7, 2024
Merged

Move the active tab in user settings to the dialog title #12481

merged 11 commits into from
May 7, 2024

Commits on May 1, 2024

  1. Convert tabbedview to functional component 

    The 'Tab' is still a class, so now it's a functional component that
has a supporting class, which is maybe a bit... jarring, but I think
is actually perfectly logical.
    @dbkr
    dbkr committed May 1, 2024
    Configuration menu
    Copy the full SHA
    38a8afe View commit details
    Browse the repository at this point in the history

  2. put comment back

    @dbkr
    dbkr committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8013f87 View commit details
    Browse the repository at this point in the history

  3. Fix bad tab ID behaviour

    @dbkr
    dbkr committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5b644b9 View commit details
    Browse the repository at this point in the history

  4. Make TabbedView a controlled component 

    This does mean the logic of keeping what tab is active is now in each
container component, but for a functional component, this is a single
line. It makes TabbedView simpler and the container components always
know exactly what tab is being displayed rather than having to effectively
keep the state separately themselves if they wanted it.

Based on #12478
    @dbkr
    dbkr committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a79b5fd View commit details
    Browse the repository at this point in the history

  5. Move the active tab in user settings to the dialog title 

    Separated by a colon, as per the new design.
    @dbkr
    dbkr committed May 1, 2024
    Configuration menu
    Copy the full SHA
    03e884d View commit details
    Browse the repository at this point in the history

  6. Update snapshots

    @dbkr
    dbkr committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a314d9f View commit details
    Browse the repository at this point in the history

  7. Update a playwright test

    @dbkr
    dbkr committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4157d88 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Fix more tests / snapshots

    @dbkr
    dbkr committed May 2, 2024
    Configuration menu
    Copy the full SHA
    64e8db5 View commit details
    Browse the repository at this point in the history

  2. Attempt to test all the cases of titleForTabID

    @dbkr
    dbkr committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0f70e81 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. More tests

    @dbkr
    dbkr committed May 3, 2024
    Configuration menu
    Copy the full SHA
    f2fca6b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into dbkr/user_settings… 

    …_title
    @dbkr
    dbkr committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1d9531d View commit details
    Browse the repository at this point in the history