Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix avatar stretched on 1:1 call #12494

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

I-lander
Copy link
Contributor

@I-lander I-lander commented May 3, 2024

Fixes element-hq/element-web#27427

In a 1:1 private conversation with another person, when receiving a call, the avatar icon is stretch :

As it is:
2024-05-03_10-21

As it should be:
2024-05-03_10-20

The issue is due to the flex box of the parent element > mx_IncomingLegacyCallToast
As there is no align-item property, the elements can be strectched.

To test:

  1. Call anybody in a 1:1 room

Signed-off-by: I-lander Ilan.varillon@gmail.com

@I-lander I-lander requested a review from a team as a code owner May 3, 2024 10:13
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 3, 2024
@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label May 3, 2024
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
I tested the change and it is working.

We need you to sign-off your contribution.

@I-lander
Copy link
Contributor Author

I-lander commented May 4, 2024

@florianduros I signed off :)

@I-lander I-lander closed this May 4, 2024
@I-lander I-lander reopened this May 4, 2024
@I-lander
Copy link
Contributor Author

I-lander commented May 4, 2024

Thank you for your contribution. I tested the change and it is working.

We need you to sign-off your contribution.

I signed off the pr

@florianduros florianduros self-requested a review May 6, 2024 08:10
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@florianduros florianduros added this pull request to the merge queue May 6, 2024
Merged via the queue into matrix-org:develop with commit c121167 May 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar display issue on 1:1 call
2 participants